Conversation
Member
|
@ddtm Some tests are now failing. Also have you actually tested it? |
MarcCote
approved these changes
Feb 2, 2017
Member
MarcCote
left a comment
MarcCote
left a comment
There was a problem hiding this comment.
A few small typos and comments. Thanks for the PR.
| parser.error("Unknown queue, --coresPerNode/--gpusPerNode and --walltime must be set.") | ||
| if args.coresPerCommand < 1: | ||
| parser.error("coresPerNode must be at least 1") | ||
| parser.error("coresPerCommand must be at least 1") |
| parser.error("coresPerNode must be at least 1") | ||
| parser.error("coresPerCommand must be at least 1") | ||
| if args.memPerCommand is not None and args.memPerCommand <= 0: | ||
| parser.error("memPerCommand must be positive") |
smartdispatch/job_generator.py
Outdated
|
|
||
| pbs.add_resources(nodes=resource) | ||
|
|
||
| if mem_per_command is not None: |
Member
There was a problem hiding this comment.
This cannot be None anymore, thanks to the if above.
| assert_equal(job_generator.pbs_list[0].modules, self.modules) | ||
|
|
||
| def test_generate_pbs2_mem(self): | ||
| # Should need two PBS file |
| assert_equal(job_generator.pbs_list[1].commands, self.commands[2:]) | ||
|
|
||
| def test_generate_pbs4_mem(self): | ||
| # Should needs four PBS file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #42.